feat!: Uncouple uswds style

[jpandersen87]

Summary

This PR removes the @forward 'uswds' line from the project's style index. This fixes the issue of uswds styles being included in the project's index.css file. Storybook's custom stylesheet has been updated to not reference the project's style index as the preview module is independently importing it along with uswds directly.

Related Issues or PRs

closes #2270

How To Test

• build
• verify that index.css does not contain uswds styles

[sawyerh]

This seems like a nice performance quick win, thanks for doing this @jpandersen87.

[kleinschmidtj]

LGTM!

[brandonlenz]

Has this been tested on a react-uswds consuming project?

Usually that's done by updating the project dependency to the head commit of this branch:

"dependencies": {
  "package": "git://github.com/username/package.git#commit"
}

[jpandersen87]

Has this been tested on a react-uswds consuming project?

Usually that's done by updating the project dependency to the head commit of this branch:

"dependencies": {

  "package": "git://github.com/username/package.git#commit"

}

Not directly but for our project (ReportStream) I've been maintaining manual patches that matches the new 'index.css' output with success. We would get unwanted side effects when attempting to use a higher version of uswds than the package used due to the discrepancies between the uswds embedded in the index at default settings and our style sheet with customized settings (at the time it was unknown that this was the cause 😫).

[shkeating]

does not appear to have design changes! good to go

[mdmower-csnw]

Has this been tested on a react-uswds consuming project?

Usually that's done by updating the project dependency to the head commit of this branch:

"dependencies": {
  "package": "git://github.com/username/package.git#commit"
}

@brandonlenz

I'm still using v5 of @trussworks/react-uswds on a project so I cherry-picked these changes on top of v5.5.0 (see fork). My package.json dependency looks like this:

"@trussworks/react-uswds": "github:mdmower-csnw/react-uswds#5.5.0-uncouple-uswds-style",

The new size of node_modules/@trussworks/react-uswds/lib/index.css is only 3KB. The website still looks just like I expect, too.

[brandonlenz]

Updated title to make this a major version change, since when this merges I want this to be noted as potentially breaking due to being a large enough change. Will make life easier for consumers if they run into challenges due to a different setup

[brandonlenz]

I see this was merged! Its a good change, I never did get around to testing it on one of our projects though. 🤞🏻 my hesitation is just paranoia