Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds story using validation prop for Alert component #2504

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

kleinschmidtj
Copy link
Contributor

Summary

Adds a story for the <Alert> component showing use of the validation prop.

Currently none of the stories make use of this prop and for documentation purposes, it's a good idea to demonstrate this. I've lifted the content from the Validation component from USWDS.

Closes #2502

How To Test

  1. yarn run storybook
  2. Go to: http://localhost:9009/?path=/story/components-alert--with-validation

Screenshots (optional)

Screenshot 2023-07-20 at 11 39 34 AM

Screenshot 2023-07-20 at 11 40 01 AM

@kleinschmidtj kleinschmidtj requested a review from a user July 20, 2023 16:42
@kleinschmidtj kleinschmidtj changed the title Kleinschmidt/alert child bug 2502 Adds story using validation prop for Alert component Jul 20, 2023
@kleinschmidtj kleinschmidtj changed the title Adds story using validation prop for Alert component fix: Adds story using validation prop for Alert component Jul 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.

Generated by 🚫 dangerJS against 0f67266

@kleinschmidtj
Copy link
Contributor Author

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.

Generated by 🚫 dangerJS against 42fcfd4

Note that we are already testing the use of the validation prop in Alert.test.tsx

Copy link
Contributor

@gidjin gidjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kleinschmidtj
Copy link
Contributor Author

@werdnanoslen Are you able to approve these Happo changes?

@kleinschmidtj kleinschmidtj merged commit c5176c9 into main Aug 9, 2023
5 checks passed
@kleinschmidtj kleinschmidtj deleted the kleinschmidt/alert-child-bug-2502 branch August 9, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] Alert component body to use a tag that allows more HTML tags
2 participants