This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Update to ES6 and MetaMask new API #1039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update MetaMask deprecated API -- call to `enable()` is replaced with `request()`. It is safe to say ES6, in particular `async - await` is a new standard all Javascript users know, and it is way more readable than callbacks and promise chaining. NOTE: The corresponding functions in petshop box template should be marked `async` too.
|
Thanks for the PR @jochasinga! We'll get it reviewed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable()is replaced withrequest().async - awaitis a new standard all Javascript users know, and it is way more readable than callbacks and promise chaining.NOTE: Either the corresponding functions in the
Appobject in the other petshop template should be markedasyncor add instructions here for the user to add themselves for this change.