This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Update ganache, remove stars, hopefully fix canvas growth bug, and change stats comparison #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
commented
Dec 16, 2022
davidmurdoch
commented
Dec 16, 2022
| <div className="tile is-ancestor"> | ||
| <div className="tile is-12"> | ||
| <DownloadsTile colorclassName="is-ganache" packageName="ganache-cli" startDate="2017-10-01" /> | ||
| <DownloadsTile colorclassName="is-ganache" packageName="ethereumjs-testrpc,ganache,ganache-cli,ganache-core" startDate="2016-01-08" /> |
There was a problem hiding this comment.
add all ganache packages and changes the date to include the first testrpc downloads
davidmurdoch
commented
Dec 16, 2022
| @@ -53,7 +53,7 @@ var Dashboard = React.createClass({ | |||
| <StargazersTile projects={["trufflesuite/truffle", "trufflesuite/ganache", "trufflesuite/drizzle"]}/> | |||
| </div> | |||
| </div> | |||
|
|
|||
| */} | |||
There was a problem hiding this comment.
stargazers didn't work
davidmurdoch
commented
Dec 16, 2022
| console.error(error); | ||
| callback(error); | ||
| }); | ||
| } |
There was a problem hiding this comment.
this makes it so each "Tile" can specify multiple comma-separated packages. This code downloads the stats for all packages for the Tile and combines them together.
davidmurdoch
commented
Dec 16, 2022
| var totalGrowthInDownloads = lastThreeMonths - prevThreeMonths; | ||
| var growth = Math.round(Math.abs(totalGrowthInDownloads) / prevThreeMonths * 100); | ||
| var totalGrowthInDownloads = lastSixMonths - prevSixMonths; | ||
| var growth = Math.round(Math.abs(totalGrowthInDownloads) / prevSixMonths * 100); |
There was a problem hiding this comment.
We have a lot more data than we used to, and six months will show a consistently more favorable picture, given the ebbs and flows of crypto dev
davidmurdoch
commented
Dec 16, 2022
| @@ -378,7 +400,9 @@ var DownloadsTile = React.createClass({ | |||
| <div className="tile"> | |||
| <div className="tile is-parent is-8"> | |||
| <div className={'tile is-child notification ' + this.props.colorclassName}> | |||
| {chart} | |||
| <div> | |||
There was a problem hiding this comment.
I think this extra div container will prevent the infinite growth bug. weird but maybe worth a shot!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An everything PR. enjoy!