Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix async pace #1654

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix async pace #1654

wants to merge 5 commits into from

Conversation

sfc-gh-pmardziel
Copy link
Contributor

@sfc-gh-pmardziel sfc-gh-pmardziel commented Nov 16, 2024

Description

Fixes the amark method for asynchronous use of the Pace class and adds an example notebook pace_example.ipynb demonstrating how to use the Pace class and what to expect from it.

Other details good to know for developers

Please include any other details of this change useful for TruLens developers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • New Tests
  • This change includes re-generated golden test results
  • This change requires a documentation update

Important

Fixes amark method in Pace class for async use, adds example notebook, and improves warning handling.

  • Behavior:
    • Fixes amark method in Pace class for asynchronous use with asyncio.Lock.
    • Adds warning mechanism to prevent repeated warnings in amark and mark methods.
    • Warns against simultaneous use of amark and mark.
  • Documentation:
    • Adds pace_example.ipynb notebook demonstrating Pace class usage.
  • Misc:
    • Fixes typo in docstring of seconds_per_period in Pace class.
    • Removes lock attribute from api.trulens.3.11.yaml.

This description was created by Ellipsis for 435cb56. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 16, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added the documentation Improvements or additions to documentation label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants