NAS-107309 / 12.1 / Add ZSTD and ZSTD-FAST to middleware #5517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Openzfs2.0 adds ZSTD and ZSTD-fast compression. This commit adds 3 levels of ZSTD and 1 level of ZSTD fast. The levels are picked based on giving a good balanced performance spread. Signed-off-by: Kjeld Schouten-Lebbing <[email protected]>
|
Can one of the admins verify this patch? |
|
ok to test |
PrivatePuffin
pushed a commit
to PrivatePuffin/webui
that referenced
this pull request
Aug 20, 2020
Openzfs2.0 adds ZSTD and ZSTD-fast compression. See: openzfs/zfs/pull/10278 This commit adds the following compression values to be accepted by the pool middleware: - ZSTD - ZSTD-5 - ZSTD-7 - ZSTD-FAST These levels give an acceptable and balanced spread of both compression ratio and performance. (see graphs in openzfs/zfs/pull/10278 ) Notes: - Requires an update to OpenZFS before being able to be used - Might also want to backport to 12U1 or even 12RC1 - Related middleware changes are also required, see: truenas/middleware/pull/5517 Signed-off-by: Kjeld Schouten-Lebbing <[email protected]>
PrivatePuffin
pushed a commit
to PrivatePuffin/webui
that referenced
this pull request
Aug 20, 2020
Openzfs2.0 adds ZSTD and ZSTD-fast compression. See: openzfs/zfs/pull/10278 This commit adds the following compression values to be accepted by the pool middleware: - ZSTD - ZSTD-5 - ZSTD-7 - ZSTD-FAST These levels give an acceptable and balanced spread of both compression ratio and performance. (see graphs in openzfs/zfs/pull/10278 ) Notes: - Requires an update to OpenZFS before being able to be used - Might also want to backport to 12U1 or even 12RC1 - Related middleware changes are also required, see: truenas/middleware/pull/5517 Signed-off-by: Kjeld Schouten-Lebbing <[email protected]>
PrivatePuffin
pushed a commit
to PrivatePuffin/webui
that referenced
this pull request
Aug 20, 2020
Openzfs2.0 adds ZSTD and ZSTD-fast compression. See: openzfs/zfs/pull/10278 This commit adds the following compression values to be accepted by the pool middleware: - ZSTD - ZSTD-5 - ZSTD-7 - ZSTD-FAST These levels give an acceptable and balanced spread of both compression ratio and performance. (see graphs in openzfs/zfs/pull/10278 ) Notes: - Requires an update to OpenZFS before being able to be used - Might also want to backport to 12U1 or even 12RC1 - Related middleware changes are also required, see: truenas/middleware/pull/5517 Signed-off-by: Kjeld Schouten-Lebbing <[email protected]>
PrivatePuffin
pushed a commit
to PrivatePuffin/webui
that referenced
this pull request
Aug 20, 2020
Openzfs2.0 adds ZSTD and ZSTD-fast compression. See: openzfs/zfs/pull/10278 This commit adds the following compression values to be accepted by the pool middleware: - ZSTD - ZSTD-5 - ZSTD-7 - ZSTD-FAST These levels give an acceptable and balanced spread of both compression ratio and performance. (see graphs in openzfs/zfs/pull/10278 ) Notes: - Requires an update to OpenZFS before being able to be used - Might also want to backport to 12U1 or even 12RC1 - Related middleware changes are also required, see: truenas/middleware/pull/5517 Signed-off-by: Kjeld Schouten-Lebbing <[email protected]>
william-gr
approved these changes
Aug 21, 2020
|
Thank you for your contribution. Waiting the openzfs port to be updated before merging this. |
|
@william-gr Thank you for your effort and indeed I fully understand the update is required before merge. 👍 |
bugclerk
pushed a commit
to truenas/webui
that referenced
this pull request
Aug 21, 2020
Openzfs2.0 adds ZSTD and ZSTD-fast compression. See: openzfs/zfs/pull/10278 This commit adds the following compression values to be accepted by the pool middleware: - ZSTD - ZSTD-5 - ZSTD-7 - ZSTD-FAST These levels give an acceptable and balanced spread of both compression ratio and performance. (see graphs in openzfs/zfs/pull/10278 ) Notes: - Requires an update to OpenZFS before being able to be used - Might also want to backport to 12U1 or even 12RC1 - Related middleware changes are also required, see: truenas/middleware/pull/5517 Signed-off-by: Kjeld Schouten-Lebbing <[email protected]> (cherry picked from commit 606c75a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openzfs2.0 adds ZSTD and ZSTD-fast compression.
See: openzfs/zfs/pull/10278
This commit adds the following compression values to be accepted by the pool middleware:
These levels give an acceptable and balanced spread of both compression ratio and performance.
(see graphs in openzfs/zfs/pull/10278 )
Notes: