NAS-132572 / 24.10.1 / Safely extract user config (by anodos325) #14994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since user is providing this file and method already replacing our configuration in many ways, the original usage doesn't pose a security risk. This change provides protection against a broken config file rewriting files outside the temporary directory used for extraction and causing undefined system behavior. This commit uses Samba's safe_tarfile wrapper to extract the file with note to replace once we have a python version from upstream debian that supports the newer tarfile feature. (cherry picked from commit 979daca)
(cherry picked from commit 9911467)
anodos325
approved these changes
Nov 20, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since user is providing this file and method already replacing our configuration in many ways, the original usage doesn't pose a security risk. This change provides protection against a broken config file rewriting files outside the temporary directory used for extraction and causing undefined system behavior.
This commit uses Samba's safe_tarfile wrapper to extract the file with note to replace once we have a python version from upstream debian that supports the newer tarfile feature.
Original PR: #14969
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132572