NAS-132169 / 24.10.1 / Make sure ix-apps mountpoint is correct (by sonicaj) #14983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user downgrades to DF or earlier and he had ix-apps dataset, and he comes back to EE or later, what will happen is that the mountpoint for ix-apps would be reset because of the logic we have in place to reset any custom mountpoints any user might have. So changes have been added to ensure that ix-apps dataset always has a consistent mountpoint set because then EE or later can treat it as apps dataset (if apps are configured) which will result in various errors as it would not be mounted where we want it to be mounted (cherry picked from commit 8ec37d2)
sonicaj
approved these changes
Nov 19, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user downgrades to DF or earlier and he had ix-apps dataset, and he comes back to EE or later, what will happen is that the mountpoint for ix-apps would be reset because of the logic we have in place to reset any custom mountpoints any user might have. So changes have been added to ensure that ix-apps dataset always has a consistent mountpoint set because then EE or later can treat it as apps dataset (if apps are configured) which will result in various errors as it would not be mounted where we want it to be mounted
Original PR: #14937
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132169