NAS-132505 / 25.04 / Remove accepts style decorator from catalog plugin #14951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
themylogin
reviewed
Nov 14, 2024
themylogin
reviewed
Nov 14, 2024
creatorcary
reviewed
Nov 14, 2024
Qubad786
force-pushed
the
mrehan/catalog-new-api-style
branch
2 times, most recently
from
b161b27
to
00d12f4
Compare
Qubad786
force-pushed
the
mrehan/catalog-new-api-style
branch
from
00d12f4
to
d18247b
Compare
yocalebo
reviewed
Nov 15, 2024
Qubad786
force-pushed
the
mrehan/catalog-new-api-style
branch
from
d18247b
to
9571f58
Compare
yocalebo
reviewed
Nov 16, 2024
Qubad786
force-pushed
the
mrehan/catalog-new-api-style
branch
from
9571f58
to
d81e53a
Compare
Qubad786
requested review from
yocalebo,
creatorcary and
themylogin
and removed request for
themylogin and
creatorcary
Qubad786
force-pushed
the
mrehan/catalog-new-api-style
branch
from
d81e53a
to
4a444fe
Compare
yocalebo
approved these changes
Nov 19, 2024
themylogin
approved these changes
Nov 19, 2024
Qubad786
force-pushed
the
mrehan/catalog-new-api-style
branch
from
4a444fe
to
90aa464
Compare
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Removes accepts style decorator from catalog plugin and uses the new api method we have in place.