Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-130694 / 24.10-RC.1 / Handle potential case when tos can be null (by sonicaj) #14485

Merged
merged 1 commit into from
Sep 10, 2024
Merged

NAS-130694 / 24.10-RC.1 / Handle potential case when tos can be null (by sonicaj) #14485

merged 1 commit into from
Sep 10, 2024

Commits on Sep 10, 2024

  1. Handle potential case when tos can be null 

    This commit fixes a case where tos can be null which we get from an ACME provider. In the database we keep it as an empty string because this needs to go through the libraries we are using to generate an ACME certificate which can/cannot error out and unfortunately we don't have an ACME provider atm which gives a null tos to test a null case. Keeping it as an empty string in that case in database if tos received is null.

(cherry picked from commit cc3da97)
    @sonicaj @bugclerk
    sonicaj authored and bugclerk committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9900b1e View commit details
    Browse the repository at this point in the history