Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130901 / 25.04 / Remove REST from test_230_idmap #14465

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Conversation

aiden3c
Copy link
Contributor

@aiden3c aiden3c commented Sep 9, 2024

I've removed querying after we create the new idmap as deleting would fail if the creation failed silently somehow.
Also renamed the file.

As always, here's a passing test (look for test_230_idmap as I hadn't changed the name of the test during this run)

@aiden3c aiden3c requested a review from a team September 9, 2024 19:40
@bugclerk
Copy link
Contributor

bugclerk commented Sep 9, 2024

@bugclerk bugclerk changed the title Remove REST from test_230_idmap NAS-130901 / 25.04 / Remove REST from test_230_idmap Sep 9, 2024
Copy link
Contributor

@creatorcary creatorcary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could still replicate test_03 by importing ValidationErrors from truenas_api_client.exc and doing something like

with pytest.raises(ValidationErrors, match=f'IdmapDomain {idmap_id} does not exist'):
    call('idmap.get_instance', idmap_id)

if you wanted to

tests/api2/test_idmap.py Show resolved Hide resolved
@aiden3c
Copy link
Contributor Author

aiden3c commented Sep 10, 2024

Running new tests, will merge once it's passed!

@aiden3c aiden3c merged commit 8b29394 into master Sep 10, 2024
3 checks passed
@aiden3c aiden3c deleted the NAS-130901 branch September 10, 2024 13:45
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants