Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create psql templates to reduce boilerplace #1668

Merged
merged 6 commits into from
Oct 28, 2023
Merged

Create psql templates to reduce boilerplace #1668

merged 6 commits into from
Oct 28, 2023

Conversation

stavros-k
Copy link
Contributor

@stavros-k stavros-k commented Oct 25, 2023

Moved some pgsql boilerplate to templates


A before and after shows that no changes are in the rendered manifests.
(Expect some autogenerated values which are unrelated with the postgres template)

❯ diff before.yaml after.yaml 
18,19c18,19
<   DATABASE_URL: postgres://briefkasten:9whT917ZrY7u07RBtkdM25K2ZWzgK0Mo@release-name-briefkasten-postgres:5432/briefkasten?sslmode=disable
<   NEXTAUTH_SECRET: 1tSDP7nXPIrUa8rRADCbGy2ncNug2mSxPjvcsbXKYN8h34m2aUclEpSNyN3jU9fp
---
>   DATABASE_URL: postgres://briefkasten:WHBmBy8O6TCKddnSCy1sgfkt0YOfGbM8@release-name-briefkasten-postgres:5432/briefkasten?sslmode=disable
>   NEXTAUTH_SECRET: 6OlGAqXY2IlGDyUfelFlVwDkKPIcqw8Ys7yJRlASPDoYXhdZfAqoIoq1ippKs9iy
41,42c41,42
<   POSTGRES_PASSWORD: 9whT917ZrY7u07RBtkdM25K2ZWzgK0Mo
<   POSTGRES_URL: postgres://briefkasten:9whT917ZrY7u07RBtkdM25K2ZWzgK0Mo@release-name-briefkasten-postgres:5432/briefkasten?sslmode=disable
---
>   POSTGRES_PASSWORD: WHBmBy8O6TCKddnSCy1sgfkt0YOfGbM8
>   POSTGRES_URL: postgres://briefkasten:WHBmBy8O6TCKddnSCy1sgfkt0YOfGbM8@release-name-briefkasten-postgres:5432/briefkasten?sslmode=disable
171c171
<         rollme: "7tNbe"
---
>         rollme: "N43vO"
407c407
<         rollme: "uBT1v"
---
>         rollme: "CiJ3t"
608c608
<         rollme: "mmzT4"
---

@stavros-k stavros-k marked this pull request as ready for review October 25, 2023 18:27
@stavros-k stavros-k self-assigned this Oct 25, 2023
@stavros-k stavros-k changed the title Create more psql templates to reduce boilerplace Create psql templates to reduce boilerplace Oct 25, 2023
@stavros-k stavros-k merged commit e272638 into master Oct 28, 2023
25 checks passed
@stavros-k stavros-k deleted the psql-template branch October 28, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants