This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Refactor severity to use monitor thresholds #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our team we wanted a way to centralize the management of both our monitors, but also the conditional notifications in the monitors' messages. This PR ties a team's severity notifications to the alert threshold. Instead of setting a monitor to have a certain severity, the message will have conditional blocks containing the appropriate notification channels based on the threshold of the alert. I also put all notifications into a
is_recovery
block so that alerts auto resolve as expected.Nothing new is required in the config, and all fields are optional.
Example message: