Allow anyone to approve #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anyone can approve except the workflow initiator if they're not allowed.
fix length of issue approvers
|
What kind of testing did you do for this PR? And also thanks for contributing! |
|
bump, this would be a nice feature :) |
I've been using this internally with no issues, but honestly we always have it set to allow all reviewers since it's private repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
approversfield optional, and allow anyone to approve if it's empty.I had to rework
approvalFromCommentsto make this work, since it worked by removing names from the required approvers list until the list was small enough.closes #108