Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

chore: Update README.md to reflect array order significance #79

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

helmturner
Copy link
Contributor

PR Checklist

Overview

Update docs to point out potential gotcha re: array order of custom serializers

@vercel
Copy link

vercel bot commented Oct 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tupleson-async ✅ Ready (Inspect) Visit Preview Oct 22, 2023 9:57am

@helmturner helmturner requested a review from KATT October 22, 2023 09:57
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #79 (5d8266c) into main (d969451) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files          30       30           
  Lines        1827     1827           
  Branches      194      194           
=======================================
  Hits         1759     1759           
  Misses         66       66           
  Partials        2        2           
Flag Coverage Δ
unit 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KATT KATT marked this pull request as ready for review October 22, 2023 10:03
@KATT KATT changed the title Update README.md to reflect array order significance chore: Update README.md to reflect array order significance Oct 22, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@KATT KATT merged commit fc356de into main Oct 22, 2023
17 checks passed
@KATT KATT deleted the docs-update-helmturner branch October 22, 2023 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants