Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

fix: close eventSource on stream end #76

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix: close eventSource on stream end #76

merged 2 commits into from
Oct 20, 2023

Conversation

KATT
Copy link
Member

@KATT KATT commented Oct 20, 2023

No description provided.

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tupleson-async ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 0:48am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #76 (f1da202) into main (3e469d5) will increase coverage by 0.17%.
Report is 1 commits behind head on main.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   94.62%   94.79%   +0.17%     
==========================================
  Files          30       30              
  Lines        1785     1786       +1     
  Branches      182      182              
==========================================
+ Hits         1689     1693       +4     
+ Misses         94       91       -3     
  Partials        2        2              
Flag Coverage Δ
unit 94.79% <83.33%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/async/createTsonAsync.ts 100.00% <100.00%> (ø)
src/async/deserializeAsync.ts 94.35% <0.00%> (+0.87%) ⬆️

@KATT KATT merged commit 2cdfc8c into main Oct 20, 2023
14 of 15 checks passed
@KATT KATT deleted the do-not-reconnect branch October 20, 2023 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant