This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
fix: deserializeAsync
string chunks can split anywhere
#30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String chunks can split the string anywhere and shouldn't be assumed to imply a new line.
This PR insures that
deserializeAsync
always accumulates the original string from the received chunks before splitting it into separate lines. Before this change, it was assumed that "end of chunk" means "end of line" even if the\n
char wasn't in the original string.It also adds a test in
deserializeAsync
that verifies it still works with weird chunk splits. Test didn't pass before this PR, passes now.Sorry for the branch name / PR formatting, I haven't contributed to tRPC in a while I don't remember the conventions