Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

how circular references maybe could work #14

Closed
wants to merge 1 commit into from
Closed

how circular references maybe could work #14

wants to merge 1 commit into from

Conversation

KATT
Copy link
Member

@KATT KATT commented Oct 1, 2023

  • make tsonCircular a factory function that is initialized every time we start serializing/deserializing
  • make sure the circular is walked at the same time
  • if a value is visited with a parent that has the same ref, store it with the distance

@KATT KATT marked this pull request as draft October 1, 2023 00:41
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@KATT KATT closed this Oct 1, 2023
@KATT KATT deleted the circular branch October 1, 2023 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant