Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix wrong link in CONTRIBUTING.zh_CN.md file #12

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

longyue0521
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@longyue0521
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

liuzengh added a commit to trpc-group/cla-database that referenced this pull request Oct 20, 2023
@sandyskies
Copy link

better change title to "Docs: fix wrong link in CONTRIBUTING.zh_CN.md file"

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97ceea4) 77.82123% compared to head (9d31c78) 77.82123%.

Additional details and impacted files
@@              Coverage Diff              @@
##                main         #12   +/-   ##
=============================================
  Coverage   77.82123%   77.82123%           
=============================================
  Files             45          45           
  Lines           3580        3580           
=============================================
  Hits            2786        2786           
  Misses           581         581           
  Partials         213         213           
Flag Coverage Δ
unittests 77.82123% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@longyue0521 longyue0521 changed the title fix: wrong link in CONTRIBUTING.zh_CN.md file Docs: fix wrong link in CONTRIBUTING.zh_CN.md file Oct 20, 2023
@longyue0521
Copy link
Contributor Author

better change title to "Docs: fix wrong link in CONTRIBUTING.zh_CN.md file"

Done

Copy link
Contributor

@WineChord WineChord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WineChord WineChord merged commit 34d5a82 into trpc-group:main Oct 23, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
@longyue0521 longyue0521 deleted the fix_link branch October 23, 2023 02:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants