Update package name of ESMPy #18
Conversation
…ed from 'ESMF' to 'esmpy' as of v8.4.0)
|
Hi, thank you for your making the model2roms package! I also sent you an email with more context. |
… module numpy has no attribute float'
…this commit solves 'NameError:name x is not defined' for x=atmosForcing & years & getERA5_1DAYfilename; and 'AttributeError: module grd has no attribute grdClass'; now stuck at NameError for x=nor
There was a problem hiding this comment.
Could you explain why we should change from np.float to float?
There was a problem hiding this comment.
I had the following error:
$ python runM2R.py
test
INFO:root:[M2R_run] Initialized logging
INFO:root:[M2R_run] Started model2roms
[...]
INFO:root:[M2R_interp2D] ==> regridSrc2Dst from RHO to U, V and RHO points
Traceback (most recent call last):
File "/export/lv6/user/jscheen/code_other_repos/model2roms/runM2R.py", line 51, in <module>
run()
File "/export/lv6/user/jscheen/code_other_repos/model2roms/runM2R.py", line 34, in run
model2roms.convert_MODEL2ROMS(confM2R)
File "/export/lv6/user/jscheen/code_other_repos/model2roms/model2roms.py", line 416, in convert_MODEL2ROMS
IOsubset.find_subset_indices(confM2R.grdMODEL, min_lat=confM2R.subset[0], max_lat=confM2R.subset[1],
File "/export/lv6/user/jscheen/code_other_repos/model2roms/IOsubset.py", line 43, in find_subset_indices
res = np.zeros((Turns, 4), dtype=np.float) ^^^^^^^^
File "/export/lv6/user/jscheen/.conda/envs/model2roms_env/lib/python3.12/site-packages/numpy/__init__.py", line 324, in __getattr__
raise AttributeError(__former_attrs__[attr])
AttributeError: module 'numpy' has no attribute 'float'.
`np.float` was a deprecated alias for the builtin `float`. To avoid this error in existing code, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations.I followed the advice written there to change np.float into float. I believe the functioning is the same. Whether you get this error, probably depends on the numpy version. I am using numpy version 1.24.3
There was a problem hiding this comment.
Perhaps you could ensure that the code change mentioned here works and if so remove the questions and comments concerned with your code change ("# Is 'grd.Grd' correct? used to be 'grd.grdClass'
# unfinished code; 'nor' & 'mytype' not defined")?
There was a problem hiding this comment.
Thank you for looking at my suggested code changes!
I am trying to get the entire atmos running without errors, but I am not finished yet. I came further than this line now and I just made a new commit (also removing those vague comments). I will continue another time and will let you know here once I succeed (or not).
There was a problem hiding this comment.
Ok sounds good. Let me know when you have updated the code to a version that is clean and runs and I will look at your changes again and merge your code with mine
…hanges in layout of code snippets
…ors; remove vague comments of @05aeaacd
Because ESMpy was renamed from 'ESMF' to 'esmpy' in v8.4.0
which gave an ImportError for 'import ESMF'.
Supports both names of ESMpy.