Workflow multiline #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce (GoogleCloudPlatform#9297) * Use send_empty_value for replicaCount in Redis Cluster * Add generated test for redis cluster * Update the template file and remove the genereated file --------- Co-authored-by: Demitri Swan <[email protected]>
…loudPlatform#9291) * feat: promoted identity-service-config * feat: removed additional GA restrictions on prop
…_config resource (GoogleCloudPlatform#9248) * Removing ForceNew from taint in change in a nodepool node_config The context for this, even if I didn't find that API doc, is that gcloud and the Console UI do not require the node_pool recreation. * Update resource_container_node_pool.go.erb * Nodepool NodeConfig Taint update func * TestAccContainerNodePool_withTaintsUpdate * Update resource_container_node_pool_test.go.erb * Update resource_container_node_pool_test.go.erb * update ForceNew fields as per the review
…dPlatform#9300) * Add admin_groups field to the containerattached resource. * Fix whitespace --------- Co-authored-by: Sarah French <[email protected]>
…y_commitment_id is unspecified (GoogleCloudPlatform#9293) * handle bigquery_reservation_capacity_commitment creation when capacity_commitment_id is unspecified * revert change to import_format * fix indentation * add custom import * add custom import file
* Add provider attribute universe_domain * Replace universe domain field with env vars, added more tests for storage and pubsub * Extract universe domain from SA key file * Include JWT scoped flow for authentication * Add JWT Scoped flow in default application credentials * Add test for GDU, enhance logging * Resolve build issue * Create package for tests, resolve review discussions * Modify logic to copy test files to down-streams * Change test package name from universe_test to universe * Update indentation on framework_config.go.erb * Update indentation on framework_config.go.erb * Update credential logging message Co-authored-by: Riley Karson <[email protected]> * Remove universe_domain replacement in utils.go for long URL replacement * Update error message for conflicted universe_domain definition * Add basic description for universe_domain. * Modify error message when universe domain mismatches --------- Co-authored-by: Riley Karson <[email protected]>
* First commit for VPC sub-segmentation feature. All relevant resources and tests updated. * Adding access levels instead of using a fake access level name. Also moving a VPC network to the top level instead of (incorrectly) inside another resource. * Fixing conflict between ip_subnetworks and vpc_ip_subnetworks * Undoing changes to access level condition test * Undoing changes to access level condition test * Ran gofmt * Re-adding access level conditions tests * Changing resource names to camel case to match what the HTTP response from the API returns. Also removing the 'resource' field because it's behind an allowlist. * Parameterizing the names of VPC networks created in tests * Fixing access level condition test * Fixed formatting with gofmt * Added missing fields in egress_from for service perimeter test. * Added "required: true" for AccessLevel.VpcNetworkSource.network field to match description. * Added egress source changes to test data in: example_access_context_manager_service_perimeter.tfplan.json * Add Egress Source/source restriction changes to example_access_context_manager_service_perimeter.tf * Attempt to fix example_access_context_manager_service_perimeter.tfplan.json to make it parse correctly * Add Egress Source to expected tcg test result data * Fixing expected output format in example_access_context_manager_service_perimeter.json * Fix Access Level format in expected output in example_access_context_manager_service_perimeter.json --------- Co-authored-by: vgm <[email protected]> Co-authored-by: Viktor Moros <[email protected]>
* Revert "Skip generated tests for google_tpu_v2_vm (GoogleCloudPlatform#9315)" This reverts commit 5dc9f2e. * Add remaining fields to TPU VM resource * Change update test to use preemptible vm * Retain disk in test so that it isn't removed prematurely * Add networking fields * Respond to PR comments * More tweaks from PR comments * Tweak test names based on feedback
…figuration in internal test (GoogleCloudPlatform#9337)
…m#9307) Co-authored-by: Igor Dyczko <[email protected]>
Co-authored-by: Edward Sun <[email protected]>
…oogleCloudPlatform#9341) * Adding support for cloud sql zone selection * Fixing spaces/tabs indentation * Fixing indetnation * Fixing blank line * Trigger Presubmits --------- Co-authored-by: Khaled Hassan <[email protected]>
…Feature (GoogleCloudPlatform#9341)" (GoogleCloudPlatform#9372) This reverts commit f3db9dd.
The current documentation is incorrect. The GPU sharing and multi-instance config are properties of the accelerator not the driverinstall
…udPlatform#9367) * feat: Add ssl_mode option to google_sql_database_instance. * Put the github.com/google/go-cmp v0.5.9 back to the go.sum. Deleted it in previous commit by mistake. * Update go.mod.erb and go.sum since the commit 6aa307c reverts the commit f3db9dd.
…m#9299) Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Shubham Sahu <[email protected]>
) * Early implementation of bucket object lock setting. * Complete implementation of object lock for buckets. * Compelete implementation, waiting for allowlist. * Tests pass against test environment. * Fixes bug in object test. * Update mmv1/third_party/terraform/services/storage/resource_storage_bucket_object.go Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/services/storage/resource_storage_bucket_object.go Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/services/storage/resource_storage_bucket_test.go.erb Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/services/storage/resource_storage_bucket_object.go Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/services/storage/resource_storage_bucket.go.erb Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Updates from review comments * Update mmv1/third_party/terraform/services/storage/resource_storage_bucket_object.go Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/website/docs/r/storage_bucket_object.html.markdown Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Removing non-deterministic date from test * Removing unused variable * fixing nested_customer_encryption anchor link --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Shubham Sahu <[email protected]>
…latform#9360) * Added Alert Policy resource field for subject line. * Added test for Alert Policy field. * Included subject in one_of lists. * Included subject in one_of lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test to run the magic-modules workflow with newlines inserted
Release Note Template for Downstream PRs (will be copied)