-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for DiffEqCallbacks to 4, (keep existing compat) #622
CompatHelper: bump compat for DiffEqCallbacks to 4, (keep existing compat) #622
Conversation
3500197
to
28589ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage 69.37% 69.37%
=======================================
Files 85 85
Lines 5124 5124
=======================================
Hits 3555 3555
Misses 1569 1569
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The tests pass, but they still seem to be using DiffEqCallbacks v3.8.0. |
I did run the tests again still 3.8.0. |
Still not being used even with 1.11 |
Done in #632 |
We should keep in mind that the tests are still using 3 instead of 4. |
I checked we are not using any of the changed features at the moment. |
This pull request changes the compat entry for the
DiffEqCallbacks
package from2.25, 3
to2.25, 3, 4
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.