Fixes for Open Boundary Systems for free surfaces #609

svchb · 2024-08-22T09:43:06Z

Depends on #610
Depends on #608
Depends on #606
Depends on #605
Depends on #603
Depends on #599

…or_free_surface

…for_free_surface

…bs_for_free_surface

codecov · 2024-08-22T09:54:50Z

Codecov Report

Attention: Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (dd75d48) to head (0dab347).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...oundary/open_boundary/method_of_characteristics.jl	44.44%	5 Missing ⚠️
src/schemes/boundary/open_boundary/system.jl	69.23%	4 Missing ⚠️
...c/schemes/boundary/open_boundary/boundary_zones.jl	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
- Coverage   68.74%   68.71%   -0.04%     
==========================================
  Files          86       86              
  Lines        5282     5299      +17     
==========================================
+ Hits         3631     3641      +10     
- Misses       1651     1658       +7

Flag	Coverage Δ
unit	`68.71% <66.66%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

…rface

Conflicts: test/examples/examples.jl

examples/fluid/pipe_flow_2d.jl

examples/fluid/pipe_flow_3d.jl

src/schemes/boundary/open_boundary/boundary_zones.jl

src/schemes/boundary/open_boundary/method_of_characteristics.jl

src/setups/extrude_geometry.jl

test/schemes/boundary/open_boundary/boundary_zone.jl

Co-authored-by: Erik Faulhaber <[email protected]>

efaulhaber

LGTM once the last conversation is solved.

* set test up for 1.11 * fix * typo * fix again * remove soundspeed from OBS * skip empty system * fix test * fix tests * fix tests * fix bug * fix * check dimensionality of reference functions * propagate characteristics * update * cleanup * update * Increase errors for 1.11 * Fix invalidations * Fix tests * Update ci.yml * revert * Update ci.yml * Update test/validation/validation.jl Co-authored-by: Erik Faulhaber <[email protected]> * revert changes that had no benefit * update * cleanup * include in test run * remove redundancy * revert * fix tests * fix * fix test * fix test * fix the test * fix error * Update src/schemes/boundary/open_boundary/method_of_characteristics.jl Co-authored-by: Erik Faulhaber <[email protected]> * Update test/schemes/boundary/open_boundary/boundary_zone.jl Co-authored-by: Erik Faulhaber <[email protected]> * Update src/setups/extrude_geometry.jl Co-authored-by: Erik Faulhaber <[email protected]> * Update src/schemes/boundary/open_boundary/method_of_characteristics.jl Co-authored-by: Erik Faulhaber <[email protected]> * Update src/schemes/boundary/open_boundary/boundary_zones.jl Co-authored-by: Erik Faulhaber <[email protected]> * Update examples/fluid/pipe_flow_3d.jl Co-authored-by: Erik Faulhaber <[email protected]> * fix test * fix test * format * fix test * format --------- Co-authored-by: LasNikas <[email protected]> Co-authored-by: Erik Faulhaber <[email protected]>

svchb and others added 16 commits August 8, 2024 11:36

set test up for 1.11

ed83ea1

Merge branch 'main' into prepare_for_1.11

493e26b

fix

bf4bea2

typo

f629239

fix again

7d5a5fc

remove soundspeed from OBS

9f7d1c1

Merge branch 'main' into remove_soundspeed

5c4734c

skip empty system

a01311c

fix test

24a21fc

fix tests

dcecbe0

fix tests

6151f7f

fix bug

43e89fd

Merge remote-tracking branch 'origin/apply_samesys_dd' into fix_obs_f…

da719c8

…or_free_surface

Merge remote-tracking branch 'origin/remove_soundspeed' into fix_obs_…

1ba97a5

…for_free_surface

Merge remote-tracking branch 'origin/skip_empty_system_io' into fix_o…

3678983

…bs_for_free_surface

Merge branch 'fix-moving-boundaries' into fix_obs_for_free_surface

b164e7a

svchb added bug Something isn't working enhancement New feature or request labels Aug 22, 2024

fix

0091cc3

svchb marked this pull request as draft August 22, 2024 12:00

svchb added 3 commits August 23, 2024 11:27

check dimensionality of reference functions

fbaf108

propagate characteristics

e720529

update

7400487

svchb mentioned this pull request Sep 27, 2024

Implement Morris surface tension model #584

Open

svchb added 5 commits October 7, 2024 17:29

Merge remote-tracking branch 'upstream/main' into fix_obs_for_free_su…

5ebc4e7

…rface

cleanup

550146f

update

90766fe

Merge branch 'main' into prepare_for_1.11

31b2f75

Merge branch 'main' into prepare_for_1.11

1d05304

svchb added 5 commits October 11, 2024 17:41

fix test

bdd6756

Merge branch 'main' into fix_obs_for_free_surface

cde7990

fix the test

1ec7eac

Merge branch 'main'

dcc7001

Conflicts: test/examples/examples.jl

fix error

d8d6d4b

svchb mentioned this pull request Nov 14, 2024

Wetting model for CSF Surface Tension Models #666

Draft

efaulhaber assigned svchb Nov 14, 2024

efaulhaber requested changes Nov 15, 2024

View reviewed changes

svchb and others added 7 commits November 15, 2024 15:43

Update src/schemes/boundary/open_boundary/method_of_characteristics.jl

aa53a4d

Co-authored-by: Erik Faulhaber <[email protected]>

Update test/schemes/boundary/open_boundary/boundary_zone.jl

eefcd6c

Co-authored-by: Erik Faulhaber <[email protected]>

Update src/setups/extrude_geometry.jl

9402b4a

Co-authored-by: Erik Faulhaber <[email protected]>

Update src/schemes/boundary/open_boundary/method_of_characteristics.jl

f1de160

Co-authored-by: Erik Faulhaber <[email protected]>

Update src/schemes/boundary/open_boundary/boundary_zones.jl

ba98d18

Co-authored-by: Erik Faulhaber <[email protected]>

Update examples/fluid/pipe_flow_3d.jl

e0ede3e

Co-authored-by: Erik Faulhaber <[email protected]>

Merge branch 'main' into fix_obs_for_free_surface

c4fcc16

svchb requested a review from efaulhaber November 16, 2024 12:25

svchb added 3 commits November 16, 2024 13:28

fix test

e0eb153

fix test

2533ed0

format

4899d08

efaulhaber requested changes Nov 18, 2024

View reviewed changes

svchb added 2 commits November 18, 2024 15:23

fix test

f4178bb

format

dc357db

svchb requested a review from efaulhaber November 18, 2024 14:24

efaulhaber approved these changes Nov 18, 2024

View reviewed changes

Merge branch 'main' into fix_obs_for_free_surface

0dab347

efaulhaber enabled auto-merge (squash) November 18, 2024 14:27

LasNikas approved these changes Nov 18, 2024

View reviewed changes

efaulhaber merged commit c744cad into trixi-framework:main Nov 18, 2024
12 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for Open Boundary Systems for free surfaces #609

Fixes for Open Boundary Systems for free surfaces #609

svchb commented Aug 22, 2024 •

edited

Loading

codecov bot commented Aug 22, 2024 •

edited

Loading

efaulhaber left a comment

Fixes for Open Boundary Systems for free surfaces #609

Fixes for Open Boundary Systems for free surfaces #609

Conversation

svchb commented Aug 22, 2024 • edited Loading

codecov bot commented Aug 22, 2024 • edited Loading

Codecov Report

efaulhaber left a comment

Choose a reason for hiding this comment

svchb commented Aug 22, 2024 •

edited

Loading

codecov bot commented Aug 22, 2024 •

edited

Loading