Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ideal gas equation #607

Merged
merged 40 commits into from
Nov 20, 2024
Merged

Add ideal gas equation #607

merged 40 commits into from
Nov 20, 2024

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented Aug 20, 2024

depends on #599
extracted from #584
output (1)
output (2)

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.54%. Comparing base (1d007c0) to head (1cab8eb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/visualization/write2vtk.jl 0.00% 4 Missing ⚠️
...s/fluid/weakly_compressible_sph/state_equations.jl 92.30% 1 Missing ⚠️
...es/fluid/weakly_compressible_sph/state_equation.jl 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
+ Coverage   68.47%   68.54%   +0.07%     
==========================================
  Files          87       87              
  Lines        5360     5389      +29     
==========================================
+ Hits         3670     3694      +24     
- Misses       1690     1695       +5     
Flag Coverage Δ
unit 68.54% <80.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@svchb svchb added the enhancement New feature or request label Aug 20, 2024
@svchb svchb mentioned this pull request Oct 10, 2024
examples/fluid/dam_break_2d.jl Outdated Show resolved Hide resolved
src/schemes/fluid/weakly_compressible_sph/system.jl Outdated Show resolved Hide resolved
examples/fluid/dam_break_2phase_2d.jl Outdated Show resolved Hide resolved
examples/fluid/dam_break_2phase_2d.jl Outdated Show resolved Hide resolved
examples/fluid/dam_break_2phase_2d.jl Outdated Show resolved Hide resolved
@efaulhaber
Copy link
Member

Blocked by #669.

@svchb svchb enabled auto-merge (squash) November 20, 2024 14:36
@svchb svchb merged commit 07fa6f0 into trixi-framework:main Nov 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants