Don't use designated initializers in CuptiPCSampling.cpp as it relates to c++20
#5291
+52
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes to c++20 Signed-off-by: Anatoly Myachev <[email protected]>
Jokeren
requested changes
Nov 30, 2024
| .cubinSize = size, | ||
| .cubin = cubin, | ||
| .cubinCrc = 0, | ||
| /*size=*/CUpti_GetCubinCrcParamsSize, |
There was a problem hiding this comment.
The change is fine to me but I would like all the assignment comments to be changed to
/*variable name=*/
by adding an equal sign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Jokeren,
these changes relates to your PR: #4674, so I would like to ask if this was done on purpose? (considering that the project declares support for the c++17 standard).
I discovered this while trying to compile proton using MSVC. It looked like this:
\CuptiPCSampling.cpp(18): error C7555: use of designated initializers requires at least '/std:c++20'.This might also be a good opportunity to ask you about your plans to transition Triton to
с++20.