[AMD] remove driver C compilation steps #5228
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
commented
Nov 22, 2024
Comment on lines
+73
to
+74
| if launch_enter_hook or launch_exit_hook: | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Presumably these are actually used somehow? But I couldn't tell from the currently emitted trampoline. Happy to add support for this as well.
There was a problem hiding this comment.
These hooks are used by proton to record profile scope information.
makslevental
force-pushed
the
makslevental/hip-driver
branch
from
ce1b20e
to
b65d8bf
Compare
makslevental
force-pushed
the
makslevental/hip-driver
branch
from
b65d8bf
to
a607c85
Compare
makslevental
changed the title
peterbell10
reviewed
Nov 22, 2024
Comment on lines
+73
to
+74
| if launch_enter_hook or launch_exit_hook: | ||
| raise NotImplementedError |
There was a problem hiding this comment.
These hooks are used by proton to record profile scope information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python can directly call C APIs via ctypes. Since the HIP APIs we use are indeed C APIs, the AMD driver does not need to compile anything (neither the kernel launch trampoline nor the utils).
The added file
hip.pyis generated from HIP headers using clang2py (and then trimmed down to include only our used APIs).Note, I've tested this on our
mi3002x.