Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMD] Use rocdl instr.sched.barriers from upstream MLIR/ROCDL #4939

Closed

Conversation

ravil-mobile
Copy link
Contributor

[AMD] use rocdl instr.sched.barriers from upstream MLIR/ROCDL

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because FILL THIS IN.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

@ravil-mobile ravil-mobile changed the title Ravil/instr sched rocdl [AMD] Use rocdl instr.sched.barriers from upstream MLIR/ROCDL Oct 17, 2024
@antiagainst
Copy link
Collaborator

Can you roll the changes here into #4940?

@ravil-mobile
Copy link
Contributor Author

Can you roll the changes here into #4940?

Thanks. Will be done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants