feat: Support sending additional outputs from vLLM inference #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [WIP] Add additional outputs to auto complete * [WIP] Use individual input tensor to control per additional output * [WIP] Parse additional output flags from request
kthui
force-pushed
the
jacky-vllm-additional-outputs
branch
from
264d387 to
9fc7d0b
Compare
* Add additional outputs test * Update copyright * Some test enhancement and notes
kthui
force-pushed
the
jacky-vllm-additional-outputs
branch
from
9fc7d0b to
5e605ca
Compare
kthui
changed the title
rmccorm4
reviewed
Nov 6, 2024
rmccorm4
reviewed
Nov 6, 2024
rmccorm4
reviewed
Nov 6, 2024
rmccorm4
reviewed
Nov 7, 2024
krishung5
reviewed
Nov 7, 2024
rmccorm4
previously approved these changes
Nov 7, 2024
krishung5
previously approved these changes
Nov 7, 2024
…d into jacky-vllm-additional-outputs
rmccorm4
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Add support for sending additional outputs from vLLM. At this step, the following 3 outputs are added:
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
N/A
Where should the reviewer start?
N/A
Test plan:
A new test is added with this PR for all combinations on setting the 3 additional outputs and verifying the outputs are valid for each combination.
Caveats:
N/A
Background
Outputs supported by vLLM in addition to text output: https://github.com/vllm-project/vllm/blob/v0.6.3.post1/vllm/outputs.py#L14-L40
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A