Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: vLLM metrics optimization #66

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Sep 18, 2024

What does the PR do?

Optimize vLLM by reporting metrics in a separate thread.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • perf

Related PRs:

triton-inference-server/python_backend#379

Where should the reviewer start?

n/a

Test plan:

L0_backend_vllm/metrics_test

  • CI Pipeline ID:
    18506139

Caveats:

n/a

Background

n/a

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

n/a

@yinggeh yinggeh self-assigned this Sep 18, 2024
@yinggeh yinggeh added the enhancement New feature or request label Sep 18, 2024
@yinggeh yinggeh requested review from kthui and indrajit96 September 18, 2024 17:48
kthui
kthui previously approved these changes Sep 19, 2024
Copy link
Contributor

@kthui kthui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for optimizing the metrics reporting performance!

src/utils/metrics.py Outdated Show resolved Hide resolved
src/utils/metrics.py Outdated Show resolved Hide resolved
src/utils/metrics.py Outdated Show resolved Hide resolved
@yinggeh yinggeh requested a review from kthui September 20, 2024 18:17
@yinggeh yinggeh merged commit fe14385 into main Sep 21, 2024
3 checks passed
@yinggeh yinggeh deleted the yinggeh-DLIS-7271-vllm-metrics-optimization branch October 23, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants