Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vLLM multi gpu tests adjustments #65

Merged
merged 7 commits into from
Sep 24, 2024
Merged

vLLM multi gpu tests adjustments #65

merged 7 commits into from
Sep 24, 2024

Conversation

oandreeva-nv
Copy link
Contributor

@oandreeva-nv oandreeva-nv commented Sep 18, 2024 •
edited
Loading

TLDR: we were writing strings in json, when they should not be strings.

@oandreeva-nv oandreeva-nv requested a review from kthui September 18, 2024 00:46
kthui
kthui previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@kthui kthui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adjusting the boolean variables encoded in strings issue! LGTM overall!

src/model.py Outdated Show resolved Hide resolved
@oandreeva-nv oandreeva-nv requested a review from kthui September 20, 2024 21:27
@oandreeva-nv oandreeva-nv merged commit b71088a into main Sep 24, 2024
3 checks passed
@oandreeva-nv oandreeva-nv deleted the oandreeva_test_adjustments branch September 24, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kthui kthui kthui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oandreeva-nv @kthui