Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Report histogram metrics to Triton metrics server #56

Merged
merged 6 commits into from
Aug 16, 2024

Make metrics test more robust

10d8a69
Select commit
Loading
Failed to load commit list.
Merged

feat: Report histogram metrics to Triton metrics server #56

Make metrics test more robust
10d8a69
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Aug 16, 2024 in 4s

2 new alerts

New alerts in code changed by this pull request

  • 2 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 130 in ci/L0_backend_vllm/metrics_test/vllm_metrics_test.py

See this annotation in the file changed.

Code scanning / CodeQL

Imprecise assert Note

assertTrue(a > b) cannot provide an informative message. Using assertGreater(a, b) instead will give more informative messages.

Check notice on line 134 in ci/L0_backend_vllm/metrics_test/vllm_metrics_test.py

See this annotation in the file changed.

Code scanning / CodeQL

Imprecise assert Note

assertTrue(a > b) cannot provide an informative message. Using assertGreater(a, b) instead will give more informative messages.