Add INT64 Datatype Support for Shape Tensors in TensorRT Backend #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
tanmayv25
reviewed
Jun 10, 2024
src/instance_state.cc
Outdated
| auto it = request_shape_values.find(io_index); | ||
| for (size_t idx = 1; idx < citr->second.nb_shape_values_; idx++) { | ||
| if (it->second.GetDataType() == ShapeTensorDataType::INT32) { |
There was a problem hiding this comment.
I think the duplicate code can be reduced here. How about adding a function in the ShapeTensor class called GetDistance which returns the distance between this shape tensor and the one that gets passed in the argument.
It can take care of data type handling.
There was a problem hiding this comment.
Moved this code to ShapeTensor::GetDistance() method.
…sorrt_backend into spolisetty_dlis_6653
tanmayv25
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShapeTensorclass to handle bothint32_tandint64_tshape tensors, using an internalchardatatype buffer to store the shape tensor values.