Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Refactor core input size checks #7592

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Sep 3, 2024

What does the PR do?

Update tests to reflect changes in core.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • test

Related PRs:

triton-inference-server/core#382

Where should the reviewer start?

n/a

Test plan:

L0_input_validation--base

  • CI Pipeline ID:
    18114270

Caveats:

n/a

Background

n/a

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

n/a

@yinggeh yinggeh changed the title refactor: Refactor core input size checks test: Refactor core input size checks Sep 3, 2024
@yinggeh yinggeh added the PR: test Adding missing tests or correcting existing test label Sep 3, 2024
@yinggeh yinggeh self-assigned this Sep 3, 2024
@yinggeh yinggeh requested review from rmccorm4 and GuanLuo September 3, 2024 19:06
@yinggeh yinggeh requested a review from rmccorm4 September 3, 2024 21:32
rmccorm4
rmccorm4 previously approved these changes Sep 3, 2024
@yinggeh yinggeh merged commit ca8ae28 into main Sep 4, 2024
3 checks passed
@yinggeh yinggeh deleted the yinggeh-DLIS-7272-refactor-core-input-checks branch September 4, 2024 20:54
@yinggeh yinggeh restored the yinggeh-DLIS-7272-refactor-core-input-checks branch September 4, 2024 21:14
@yinggeh yinggeh deleted the yinggeh-DLIS-7272-refactor-core-input-checks branch September 18, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: test Adding missing tests or correcting existing test
Development

Successfully merging this pull request may close these issues.

2 participants