Add testing for decoupled model use case #7246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishung5
force-pushed
the
krish-python-finalize
branch
from
6c85d28 to
d5111c1
Compare
Tabrizian
reviewed
May 23, 2024
|
|
||
|
|
||
| class TritonPythonModel: | ||
| """This model launches a separate thread to handle the request from a queue. The thread is launched from |
There was a problem hiding this comment.
Please keep the number of characters in each line below 80.
There was a problem hiding this comment.
@dyastremsky do you know why CodeQL didn't catch this?
| wait_input = pb_utils.get_input_tensor_by_name(requests[0], "WAIT").as_numpy() | ||
| time.sleep(wait_input[0] / 1000) | ||
|
|
||
| return None |
There was a problem hiding this comment.
I was wondering if you mean remove return None? I thought we'd need to return None from execute if it's in decoupled mode.
There was a problem hiding this comment.
Not returning anything is similar to returning None.
|
Closing as per discussion a better approach would be handle this in the Triton core instead of PYBE. Filed ticket DLIS-6795 to track this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing added for the specific use case of launching a separate thread for decoupled models. Fixed a small issue for the CI as well.
PYBE: triton-inference-server/python_backend#358