Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary wait in case of failed stub creation #7192

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

indrajit96
Copy link
Contributor

Added a new "Faulty" model to repro DLIS-5819 and cause the server to hang.
The test

  1. First loads a "correct" model.
  2. Then loads a "faulty" model.

The expectation is the server should NOT hang.

faulty_model_name = "auto_complete_error"
with httpclient.InferenceServerClient(f"{_tritonserver_ipaddr}:8000") as client:
# Load a correct model
client.load_model(working_model_name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment why a working model is required to reproduce the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still trying to figure this out.
I think we can merge this Test for 24.05 and meanwhile I will continue my investigation.
We have already merged the python backend change.

krishung5
krishung5 previously approved these changes May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants