Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing for L0_iterative_tutorial #7176

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add testing for L0_iterative_tutorial #7176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7709993
Add testing for L0_iterative_tutorial
Tabrizian May 1, 2024
1d253c2
Rename
Tabrizian May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions qa/L0_tutorial_iterative_scheduling/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in the
# documentation and/or other materials provided with the distribution.
# * Neither the name of NVIDIA CORPORATION nor the names of its
# contributors may be used to endorse or promote products derived
# from this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY
# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
# OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

rm -rf tutorials
git clone https://github.com/triton-inference-server/tutorials.git -b ${TUTORIAL_REPO_TAG} --depth 1
Copy link
Collaborator

@rmccorm4 rmccorm4 May 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we default TUTORIAL_REPO_TAG for ergonomics of local testing (docker exec devel) outside of a pipeline? Something like this

TUTORIAL_REPO_TAG=${TUTORIAL_REPO_TAG:-"main"}


cd tutorials/Conceptual_Guide/Part_7-iterative_scheduling/tests
RET=0

# Install the dependencies
pip3 install "transformers[torch]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we lock down the version to whatever worked while testing to avoid unexpected breakage?


set +e
python3 test_iterative_scheduler.py
if [ $? -ne 0 ]; then
RET=1
fi

set -e

if [ $RET -eq 1 ]; then
echo -e "Iterative scheduling test failed!"
exit 1
else
echo -e "Iterative scheduling test succeeded!"
fi
Loading