-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gRPC AsyncIO request cancellation tests #6408
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,141 @@ | ||
#!/usr/bin/env python3 | ||
|
||
# Copyright 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
# | ||
# Redistribution and use in source and binary forms, with or without | ||
# modification, are permitted provided that the following conditions | ||
# are met: | ||
# * Redistributions of source code must retain the above copyright | ||
# notice, this list of conditions and the following disclaimer. | ||
# * Redistributions in binary form must reproduce the above copyright | ||
# notice, this list of conditions and the following disclaimer in the | ||
# documentation and/or other materials provided with the distribution. | ||
# * Neither the name of NVIDIA CORPORATION nor the names of its | ||
# contributors may be used to endorse or promote products derived | ||
# from this software without specific prior written permission. | ||
# | ||
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY | ||
# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR | ||
# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, | ||
# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, | ||
# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR | ||
# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY | ||
# OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
||
import asyncio | ||
import queue | ||
import time | ||
import unittest | ||
from functools import partial | ||
|
||
import numpy as np | ||
import tritonclient.grpc as grpcclient | ||
import tritonclient.grpc.aio as grpcclientaio | ||
from tritonclient.utils import InferenceServerException | ||
|
||
|
||
class UserData: | ||
def __init__(self): | ||
self._completed_requests = queue.Queue() | ||
|
||
|
||
def callback(user_data, result, error): | ||
if error: | ||
user_data._completed_requests.put(error) | ||
else: | ||
user_data._completed_requests.put(result) | ||
|
||
|
||
class GrpcCancellationTest(unittest.IsolatedAsyncioTestCase): | ||
_model_name = "custom_identity_int32" | ||
_model_delay = 10.0 # seconds | ||
_grpc_params = {"url": "localhost:8001", "verbose": True} | ||
|
||
def setUp(self): | ||
self._client = grpcclient.InferenceServerClient(**self._grpc_params) | ||
self._client_aio = grpcclientaio.InferenceServerClient(**self._grpc_params) | ||
self._user_data = UserData() | ||
self._callback = partial(callback, self._user_data) | ||
self._prepare_request() | ||
self._start_time = time.time() # seconds | ||
|
||
def tearDown(self): | ||
self._end_time = time.time() # seconds | ||
self._assert_max_duration() | ||
|
||
def _prepare_request(self): | ||
self._inputs = [] | ||
self._inputs.append(grpcclient.InferInput("INPUT0", [1, 1], "INT32")) | ||
self._outputs = [] | ||
self._outputs.append(grpcclient.InferRequestedOutput("OUTPUT0")) | ||
self._inputs[0].set_data_from_numpy(np.array([[10]], dtype=np.int32)) | ||
|
||
def _assert_max_duration(self): | ||
max_duration = self._model_delay * 0.5 # seconds | ||
duration = self._end_time - self._start_time # seconds | ||
self.assertLess( | ||
duration, | ||
max_duration, | ||
f"test runtime expected less than {max_duration}s response time, got {duration}s", | ||
) | ||
|
||
def _assert_callback_cancelled(self): | ||
self.assertFalse(self._user_data._completed_requests.empty()) | ||
data_item = self._user_data._completed_requests.get() | ||
self.assertIsInstance(data_item, InferenceServerException) | ||
self.assertIn("Locally cancelled by application!", str(data_item)) | ||
|
||
def test_grpc_async_infer(self): | ||
future = self._client.async_infer( | ||
model_name=self._model_name, | ||
inputs=self._inputs, | ||
callback=self._callback, | ||
outputs=self._outputs, | ||
) | ||
time.sleep(2) # ensure the inference has started | ||
future.cancel() | ||
time.sleep(0.1) # context switch | ||
self._assert_callback_cancelled() | ||
|
||
def test_grpc_stream_infer(self): | ||
self._client.start_stream(callback=self._callback) | ||
self._client.async_stream_infer( | ||
model_name=self._model_name, inputs=self._inputs, outputs=self._outputs | ||
) | ||
time.sleep(2) # ensure the inference has started | ||
self._client.stop_stream(cancel_requests=True) | ||
self._assert_callback_cancelled() | ||
|
||
async def test_aio_grpc_async_infer(self): | ||
infer_task = asyncio.create_task( | ||
self._client_aio.infer( | ||
model_name=self._model_name, inputs=self._inputs, outputs=self._outputs | ||
) | ||
) | ||
await asyncio.sleep(2) # ensure the inference has started | ||
infer_task.cancel() | ||
with self.assertRaises(asyncio.CancelledError): | ||
await infer_task | ||
tanmayv25 marked this conversation as resolved.
Dismissed
Show resolved
Hide resolved
rmccorm4 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
async def test_aio_grpc_stream_infer(self): | ||
async def requests_generator(): | ||
yield { | ||
"model_name": self._model_name, | ||
"inputs": self._inputs, | ||
"outputs": self._outputs, | ||
} | ||
|
||
responses_iterator = self._client_aio.stream_infer(requests_generator()) | ||
await asyncio.sleep(2) # ensure the inference has started | ||
self.assertTrue(responses_iterator.cancel()) | ||
with self.assertRaises(asyncio.CancelledError): | ||
async for result, error in responses_iterator: | ||
self._callback(result, error) | ||
|
||
|
||
if __name__ == "__main__": | ||
unittest.main() |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iman pointed that using AsyncTestCase might help simplify this testing logic?
Can you take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good reminder! We are already taking advantage of the simplification, see the class declaration, but from the native Python one (as suggested on the AsyncTestCase documentation).