Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response sender to check for improper non-decoupled model usage #363

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

kthui
Copy link
Contributor

@kthui kthui commented May 31, 2024

Previous PRs:

Related PR: triton-inference-server/server#7292

The response sender will raise an exception if any one of the following is detected:

  • Try to send more than one response on non-decoupled model.
  • Try to send complete final flag without including a response or already sent a response on non-decoupled model.

@kthui
Copy link
Contributor Author

kthui commented May 31, 2024

@kthui kthui force-pushed the jacky-res-sender-bad-model branch from 830782d to 10aafa7 Compare May 31, 2024 23:18
src/response_sender.cc Outdated Show resolved Hide resolved
src/response_sender.cc Outdated Show resolved Hide resolved
src/response_sender.cc Show resolved Hide resolved
@kthui kthui merged commit 4961e24 into jacky-res-sender-main Jun 4, 2024
3 checks passed
@kthui kthui deleted the jacky-res-sender-bad-model branch June 4, 2024 18:59
kthui added a commit that referenced this pull request Jun 6, 2024
* Add response sender to non-decoupled models and unify data pipelines (#360)

* Add response sender to non-decoupled model and unify data pipelines

* Rename variable and class name

* Fix decoupled batch statistics to account for implicit batch size (#361)

* Fix decoupled gpu output error handling (#362)

* Fix decoupled gpu output error handling

* Return full error string upon exception from model

* Response sender to check for improper non-decoupled model usage (#363)

* Response sender to check for improper non-decoupled model usage

* Force close response sender on exception

* Rename functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants