-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python backend request cancellation #304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kthui
requested review from
jbkyang-nvi,
krishung5,
Tabrizian,
tanmayv25,
nnshah1 and
rmccorm4
September 29, 2023 01:28
nnshah1
reviewed
Sep 29, 2023
Tabrizian
reviewed
Sep 29, 2023
tanmayv25
reviewed
Oct 2, 2023
tanmayv25
reviewed
Oct 4, 2023
tanmayv25
approved these changes
Oct 4, 2023
kthui
force-pushed
the
jacky-req-cancel-python
branch
from
October 4, 2023 18:54
cac2f2f
to
e3c476e
Compare
kthui
force-pushed
the
jacky-req-cancel-python
branch
from
October 5, 2023 07:24
7abe046
to
a5892b6
Compare
tanmayv25
reviewed
Oct 5, 2023
Tabrizian
reviewed
Oct 5, 2023
kthui
force-pushed
the
jacky-req-cancel-python
branch
from
October 5, 2023 21:43
29f4139
to
f4e0ae1
Compare
kthui
force-pushed
the
jacky-req-cancel-python
branch
from
October 5, 2023 21:50
f4e0ae1
to
3de5922
Compare
Tabrizian
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: triton-inference-server/server#6364
Add
is_cancelled()
check API into Python model requests, and allow Python model to respond request cancelled.