Throw warning in case of Triton API minor version mismatch #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkomali
assigned matthewkotila and ganeshku1 and unassigned matthewkotila and ganeshku1
lkomali
changed the title
ganeshku1
reviewed
Sep 19, 2024
|
I missed one of the checks, will add it. |
lkomali
force-pushed
the
lkomali-tpa-270
branch
from
3c8fcfc to
99a1a8b
Compare
lkomali
force-pushed
the
lkomali-tpa-270
branch
from
99a1a8b to
c728a4b
Compare
dyastremsky
reviewed
Sep 19, 2024
lkomali
force-pushed
the
lkomali-tpa-270
branch
from
c728a4b to
2cff0d1
Compare
dyastremsky
previously approved these changes
Sep 20, 2024
lkomali
force-pushed
the
lkomali-tpa-270
branch
from
2cff0d1 to
eeaa331
Compare
|
@matthewkotila and I discussed offline and we decided to throw a warning incase of a minor version mismatch since the updates to Triton C API PA is likely to be rare and the probability of an undefined behavior is pretty low. |
matthewkotila
approved these changes
Sep 24, 2024
dyastremsky
approved these changes
Sep 24, 2024
lkomali
added a commit
that referenced
this pull request
Oct 2, 2024
* Graceful handling of Triton API minor version mismatch * Modify conditons
dyastremsky
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Graceful handling of Triton API minor version mismatch * Modify conditons
pvijayakrish
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Adding support for TensorRT 10 APIs in the backend. Keep TRT 8 support as well (#88) * Replace binding index-based methods with name-based alternatives * Remove unused variables * Remove unused variables * Remove allInput*Specified() * Delete TRTV1Interface * Replace getProfileShapeValues() with getProfileTensorValues() * Remove buffer_bindings_ * Enhancements * Replace isExecutionBinding() * Add INT64 support * Remove hasImplicitBatchDimension() * Update Copyright * Remove unused variables * Undo copyright * Undo Copyright * Undo copyright * Fix the handling in INT64 shape tensors output * Fix data dependent output shapes * Fix pre commit errors * Update copyright * Resolve review comments * Include source for building on TRT 8 (#86) (#87) * Include source for building on TRT 8 * Apply suggestions from code review --------- Co-authored-by: Misha Chornyi <[email protected]> * Fix envvar access in CMake --------- Co-authored-by: Sai Kiran Polisetty <[email protected]> Co-authored-by: Misha Chornyi <[email protected]> * Add support for kBF16 --------- Co-authored-by: Tanmay Verma <[email protected]> Co-authored-by: Misha Chornyi <[email protected]>
lkomali
added a commit
that referenced
this pull request
Oct 31, 2024
* Graceful handling of Triton API minor version mismatch * Modify conditons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PA fails if there is a version mismatch between API_VERSION defined in core and client.
This PR modifies this behavior to
The reason for this difference is because major version change denotes breaking changes, minor version denotes additions.