Update GenAI-Perf README and tutorial doc #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debermudez
reviewed
Sep 18, 2024
debermudez
requested changes
Sep 18, 2024
dyastremsky
reviewed
Sep 18, 2024
dyastremsky
reviewed
Sep 18, 2024
dyastremsky
previously approved these changes
Sep 18, 2024
debermudez
reviewed
Sep 18, 2024
debermudez
reviewed
Sep 18, 2024
debermudez
approved these changes
Sep 19, 2024
lkomali
pushed a commit
that referenced
this pull request
Oct 2, 2024
* update doc * remove duplicate commands * make commands more simpler for user * Remove redundant sdk container docker commands * add links * update template * fix type * add article and capitalize github * set env directly
pvijayakrish
pushed a commit
that referenced
this pull request
Oct 8, 2024
…t as well (#88) (#89) * Replace binding index-based methods with name-based alternatives * Remove unused variables * Remove unused variables * Remove allInput*Specified() * Delete TRTV1Interface * Replace getProfileShapeValues() with getProfileTensorValues() * Remove buffer_bindings_ * Enhancements * Replace isExecutionBinding() * Add INT64 support * Remove hasImplicitBatchDimension() * Update Copyright * Remove unused variables * Undo copyright * Undo Copyright * Undo copyright * Fix the handling in INT64 shape tensors output * Fix data dependent output shapes * Fix pre commit errors * Update copyright * Resolve review comments * Include source for building on TRT 8 (#86) (#87) * Include source for building on TRT 8 * Apply suggestions from code review --------- * Fix envvar access in CMake --------- Co-authored-by: Sai Kiran Polisetty <[email protected]> Co-authored-by: Misha Chornyi <[email protected]>
Comment on lines
-69
to
-71
| export RELEASE="{{ release }}" | ||
|
|
||
| docker run -it --net=host --gpus=all nvcr.io/nvidia/tritonserver:${RELEASE}-py3-sdk |
There was a problem hiding this comment.
@nv-hwoo @debermudez @dyastremsky why was the SDK container run command removed from the tutorial?
I think generally a tutorial user is going to be unfamiliar, so we should give them as much copy-pasteable commands as possible so they don't get stuck.
There was a problem hiding this comment.
I don't know. The GenAi-Perf README covers installation and these are supposed to be additional examples, so it's possible Hyunjae wanted to remove redundancy.
Hyunjae will be back in a couple of weeks. We could look at whether these need to be re-added then.
lkomali
pushed a commit
that referenced
this pull request
Oct 31, 2024
* update doc * remove duplicate commands * make commands more simpler for user * Remove redundant sdk container docker commands * add links * update template * fix type * add article and capitalize github * set env directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Checkout the updated main README here
Checkout the updated Tutorial doc here