Update model used in chat tutorials #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix goodput
nv-hwoo
reviewed
Sep 9, 2024
Co-authored-by: Hyunjae Woo <[email protected]>
|
I updated the tutorial template. There's not an existing goodput template, so I created the ticket TPA-407 to add one in a separate PR. |
debermudez
approved these changes
Sep 11, 2024
lkomali
pushed a commit
that referenced
this pull request
Oct 2, 2024
pvijayakrish
pushed a commit
that referenced
this pull request
Oct 8, 2024
Co-authored-by: kyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPT2 has no default template for vLLM, so it now returns an error when used:
vLLM uses Zephyr in their tutorials. It has a chat template, so I am updating our documents to use it so that the tutorials continue to work.
I also updated a few of the nearby tutorial output tables to the current format. The goal of this PR isn't to entirely update the output tables, which can be done in a separate PR.