Graceful handling of exception thrown by genai-perf if metrics url is unreachable #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkomali
changed the title
dyastremsky
reviewed
Aug 21, 2024
genai-perf/genai_perf/telemetry_data/telemetry_data_collector.py
Outdated
Show resolved
Hide resolved
genai-perf/genai_perf/telemetry_data/telemetry_data_collector.py
Outdated
Show resolved
Hide resolved
genai-perf/genai_perf/telemetry_data/telemetry_data_collector.py
Outdated
Show resolved
Hide resolved
genai-perf/genai_perf/wrapper.py
Outdated
| telemetry_data_collector.start() | ||
| else: | ||
| logger.warning( | ||
| f"The metrics url ({telemetry_data_collector.metrics_url}) is unreachable, cannot collect telemetry data" |
There was a problem hiding this comment.
A little too long. Also a run-on sentence. We might want to make it shorter.
Something like:
The metrics url ({telemetry_data_collector.metrics_url}) is unreachable.
GenAI-Perf cannot collect telemetry data.
dyastremsky
reviewed
Aug 21, 2024
genai-perf/genai_perf/telemetry_data/telemetry_data_collector.py
Outdated
Show resolved
Hide resolved
dyastremsky
reviewed
Aug 22, 2024
genai-perf/genai_perf/wrapper.py
Outdated
| telemetry_data_collector.start() | ||
| else: | ||
| logger.warning( | ||
| f"The metrics URL ({telemetry_data_collector.metrics_url}) is unreachable." |
There was a problem hiding this comment.
Nit: Could you add a space at the end of this? Otherwise, there won't be one.
E.g.
f"The metrics URL ({telemetry_data_collector.metrics_url}) is unreachable. "
"GenAI-Perf cannot collect telemetry data."
This makes it so that instead of "...unreachable.GenAI-Perf...", the message reads "...unreachable. GenAI-Perf..."
There was a problem hiding this comment.
Did you push it? I don't see it on my end.
There was a problem hiding this comment.
yes, I did. Let me know if you still cannot see the change. There was some problem initially when I tried to update my branch and this change was overwritten I think.
dyastremsky
reviewed
Aug 22, 2024
|
Attached the screenshot of how the error message looks on the console. |
lkomali
force-pushed
the
lkomali-fix-metrics-url-exception
branch
from
933f68d to
3f32aa8
Compare
dyastremsky
approved these changes
Aug 26, 2024
lkomali
added a commit
that referenced
this pull request
Aug 27, 2024
… unreachable (#47) * Fix exception thrown by genai-perf if metrics url is unreachable * Fix comments * Fix comments * Fix comments * Add space in error message
lkomali
added a commit
that referenced
this pull request
Aug 27, 2024
… unreachable (#47) * Fix exception thrown by genai-perf if metrics url is unreachable * Fix comments * Fix comments * Fix comments * Add space in error message
dyastremsky
pushed a commit
that referenced
this pull request
Aug 27, 2024
… unreachable (#47) * Fix exception thrown by genai-perf if metrics url is unreachable * Fix comments * Fix comments * Fix comments * Add space in error message
lkomali
added a commit
that referenced
this pull request
Aug 28, 2024
* Add CLI argument for server-metrics-url * Remove print statement * Fix pre-commit error * Graceful handling of exception thrown by genai-perf if metrics url is unreachable (#47) * Fix exception thrown by genai-perf if metrics url is unreachable * Fix comments * Fix comments * Fix comments * Add space in error message * Add CLI argument for server-metrics-url * Fix pre-commit error and remove duplicates * Remove unnecessary print * Fix comments * Fix pytest error * Fix comments * Refactor test function names * Fix comments * Fix comment in test_profile_handler * Cleanup test_profile_handler.py test * Move MockArgs outside TestProfileHandler * Move test triton metrics url to a variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to gracefully handle the exception thrown by GenAI-Perf and it is logged as a warning that the url is not reachable.