Add goodput tutorial #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyastremsky
reviewed
Aug 21, 2024
genai-perf/docs/goodput.md
Outdated
|
|
||
| # Context | ||
|
|
||
| Goodput, defined as the number of completed requests per second that meet the |
There was a problem hiding this comment.
Great progress! Maybe get more specific with what goodput is from a technical lens rather than focusing on benefits. For example, something like:
Goodput is defined as the number of completed requests per second that meet
specified metric constraints, also called service level objectives.
For example, perhaps you want the throughput only including requests where
the time to first token is under 50 ns and inter-token latency is under 10ns.
GenAI-Perf provides this value as goodput.
lkomali
reviewed
Aug 21, 2024
|
Fantastic work, Andy! Approved. Note that this targets the main branch. Please be sure to merge this after the relevant feature is merged. You can also merge it to a feature branch that has all of the PRs for that feature, then open a PR for that feature branch to merge to main. |
dyastremsky
previously approved these changes
Aug 22, 2024
dyastremsky
approved these changes
Aug 23, 2024
AndyDai-nv
force-pushed
the
andy-goodput-doc
branch
from
c0e3b1f to
83626fa
Compare
dyastremsky
approved these changes
Aug 23, 2024
lkomali
pushed a commit
that referenced
this pull request
Aug 27, 2024
* Add goodput tutorial * Updated tutorial, goodput is printed inside table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking original PR into smaller PRs.
Add goodput tutorial.