Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to Sweep PA batch size #228

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Conversation

nv-braf
Copy link
Contributor

@nv-braf nv-braf commented Dec 19, 2024

Adds an option to sweep PA batch size to --sweep-type when running the analyze subcommand.
This was an oversight on my part as the logic for this was already in place in the sweep objective generator.

@nv-braf nv-braf requested a review from debermudez December 19, 2024 17:45
@nv-braf nv-braf marked this pull request as ready for review December 19, 2024 17:45
Copy link
Contributor

@debermudez debermudez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a doc soon that covers how to do this for users and for us to learn.
This PR will ungate Nic quickly. Nice job!

@nv-braf nv-braf merged commit daf1b94 into main Dec 19, 2024
6 checks passed
@nv-braf nv-braf deleted the add-pa-batch-size-sweep-option branch December 19, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants