Support input type payload for timing strategy #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkomali
changed the title
|
Should this be targeting a feature branch or is this the whole feature? Also, could you update the branch off of main? |
|
@dyastremsky Yep sorry, should base off of a feature branch. Thanks for catching that. |
dyastremsky
reviewed
Dec 7, 2024
Replace with correct variable
lkomali
force-pushed
the
lkomali-add-payload-input
branch
from
68810f1 to
bebb4a3
Compare
debermudez
reviewed
Dec 9, 2024
debermudez
approved these changes
Dec 9, 2024
dyastremsky
pushed a commit
that referenced
this pull request
Dec 17, 2024
Replace with correct variable
debermudez
pushed a commit
that referenced
this pull request
Jan 3, 2025
Replace with correct variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of timing strategy, this PR adds a new type for --input-file arg.
With this change, user can set --input-file=payload:"path-to-timing-file" to pass the file that has request level timing information.
In the input file, users can set the time at which request should be sent.
For example, {"timestamp":"1"} will send request at 1 second.