Draft: Schedule File GenAI Perf frontend #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IzzyPutterman
commented
Nov 7, 2024
| if j == args.num_prompts: | ||
| break | ||
| timings.append(float(json.loads(line)["timestamp"]) / 1000) | ||
| cmd += ["--schedule", ",".join(map(str, timings))] |
There was a problem hiding this comment.
Not sure what the expected format is for the schedule is after recent changes.
IzzyPutterman
commented
Nov 7, 2024
Comment on lines
134
to
137
| for _ in range(2): | ||
| diff = requested_prompt_tokens - get_token_length(prompt) | ||
| for _ in range(diff): | ||
| prompt = "hi " + prompt |
There was a problem hiding this comment.
This should actually always be the case to ensure consistent number of tokens in input I think
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -24,6 +24,9 @@ | |||
| # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | |||
| # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
|
|
|||
| import json | |||
| import os | |||
Check notice
Code scanning / CodeQL
Unused import Note
| @@ -24,6 +24,9 @@ | |||
| # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | |||
| # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
|
|
|||
| import json | |||
| import os | |||
| import subprocess | |||
Check notice
Code scanning / CodeQL
Unused import Note
Co-authored-by: hongkuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.