Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README and versions for 24.10 #938

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Update README and versions for 24.10 #938

merged 1 commit into from
Oct 9, 2024

Conversation

pvijayakrish
Copy link
Contributor

Updtae README and versions for 24.10

@fpetrini15 fpetrini15 changed the title Updtae README and versions for 24.10 Update README and versions for 24.10 Oct 9, 2024
fpetrini15
fpetrini15 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@fpetrini15 fpetrini15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After our discussion, I believe changing the versioning in the dockerfile is optional. I think our build will take the version from VERSION.

@pvijayakrish
Copy link
Contributor Author

The version update in Dockerfile will be done pre-NGC release.

@pvijayakrish pvijayakrish merged commit 5e9c997 into r24.10 Oct 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpetrini15 fpetrini15 fpetrini15 approved these changes

@nv-braf nv-braf Awaiting requested review from nv-braf

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvijayakrish @fpetrini15