Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding BLS composing models to SearchParameters #898

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Adding BLS composing models to SearchParameters #898

merged 2 commits into from
Jun 10, 2024

Conversation

nv-braf
Copy link
Contributor

@nv-braf nv-braf commented Jun 10, 2024

Composing models in a BLS can also have search parameters:

run_config_search_mode: optuna
use_concurrency_formula: True
profile_models: bls
bls_composing_models:
  add:
    model_config_parameters:
      max_batch_size: [1, 4, 8]
      dynamic_batching:
        max_queue_delay_microseconds: [100, 200, 300]
  sub:
    model_config_parameters:
      max_batch_size: [32, 64, 128]
      dynamic_batching:
        max_queue_delay_microseconds: [400, 500, 600]

This story adds support for this to the SearchParameters class (which is used by OptunaRCG).

@nv-braf nv-braf requested a review from debermudez June 10, 2024 19:16
debermudez
debermudez reviewed Jun 10, 2024
View reviewed changes
model_analyzer/analyzer.py Outdated Show resolved Hide resolved
model_analyzer/config/generate/search_parameters.py Outdated Show resolved Hide resolved
tests/test_search_parameters.py Outdated Show resolved Hide resolved
@nv-braf nv-braf requested a review from debermudez June 10, 2024 22:14
@nv-braf nv-braf merged commit 910a39a into add-bls-to-optuna Jun 10, 2024
4 checks passed
nv-braf added a commit that referenced this pull request Jun 18, 2024
@nv-braf
Add BLS support to Optuna (#902)
5c7e283 
* Adding BLS composing models to SearchParameters (#898)

* Adding BLS composing models to SearchParameters

* Fixes based on PR

* Adds BLS scaffolding to everything up-to OptunaRCG (#899)

* Adding BLS to OptunaRCG (#900)

* Adding BLS to OptunaRCG

* Fixing codeQL issue

* Fix based on PR + bug fix to concurrency formula

* Adding missing TODO

* Refactoring objective name creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debermudez debermudez debermudez approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nv-braf @debermudez