Adding support for concurrency formula as an option in Optuna search #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-braf
changed the title
nv-braf
force-pushed
the
config-option-for-concurrency-searching
branch
from
c2fb047 to
3447054
Compare
debermudez
reviewed
May 29, 2024
|
|
||
| self.assertEqual(model_config.to_dict()["name"], self._test_config_dict["name"]) | ||
|
|
||
| # These values are the result of using a fixed seed of 100 |
| analyzer = Analyzer(config, MagicMock(), MagicMock(), MagicMock()) | ||
| analyzer._populate_search_parameters() | ||
|
|
||
| concurrency = analyzer._search_parameters["add_sub"].get_parameter( |
There was a problem hiding this comment.
This wont error out?
get_parameter is designed to return None when a parameter isnt found?
There was a problem hiding this comment.
Yes, it will return None when the key is not found.
debermudez
approved these changes
May 29, 2024
nv-braf
added a commit
that referenced
this pull request
Jun 6, 2024
…885) * Fixing merge confilct * Adding --use-concurrency-formula to unit testing
nv-braf
added a commit
that referenced
this pull request
Jun 7, 2024
* Adding cli option for optuna search (#867) * Adding cli option for optuna search * Changed RCS description * Class to hold info about parameters (#868) * Initial code for ConfigParameters class * Fixing codeql issue * Fixes based on review * Connect up parameter description class (#869) * Added hooks for creating search parameters with some basic unit testing * Adding more unit testing * Cleaning up codeql * Adding story ref for TODO * Changes based on review comments * Refactored ConfigParameters * Renaming to SearchParameter(s) * Moving unit testing into SearchParameters test class * Fix codeql issues * Creating Optuna RCG factory (#878) * Creating optuna RCG factory * fixing codeql issues * Removing metrics manager * Fixing mypy failure * Optuna Search Class (#877) * Base Optuna class plus unit testing * codeql fixes * more codeql fixes * Removing metrics manager * Removing metrics manager from Optuna RCG unit test * Removing client from quick/optuna RCGs * Changing gpus to gpu_count in quick/optuna RCGs * Removing magic number * Fixing codeql issue * Fixing optuna version * Adding todo comment about client batch size support * Using SearchParameters in OptunaRCG (#881) * Using SearchParameters in OptunaRCG * Fixing search parameter unit tests * Removing debug line * Changes based on PR * Adding call for default parameters * Added todo for dynamic batching * Add Percentage Search Space to Optuna (#882) * Added method for calculating total possible configurations * Added min/max percentage of search space to CLI * Connected up in optuna RCG * Added in support to cap optuna search based on a strict number of trials (#884) * Adding support for concurrency formula as an option in Optuna search (#885) * Fixing merge confilct * Adding --use-concurrency-formula to unit testing * Add Debug info to Optuna (#889) * Adding debug info + bug fixes * Fixes based on PR * Optuna Early Exit (#890) * Add logic to enable early exit along with CLI hooks. * Changes based on PR * Check that model supports dynamic batching when creating param_combo (#891) * Adding option to disable concurrency sweeping (#893) * Adding support for client batch size (#892) * Adding support for client batch size * Fixes based on PR * Removing redundant keys() * Fixing codeQL issue * Attempt to fix unittest issue * Removing 3.8 testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the user the option to use our concurrency formula rather than having Optuna search the full concurrency range.
By default we allow Optuna to search the concurrency space. This gives the user the option of using our concurrency formula (2 * instance_count * batch_size) instead, which will reduce the search space and should improve the search time.